Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding / updating linux / android rules #907

Merged
merged 5 commits into from
Jun 11, 2024
Merged

adding / updating linux / android rules #907

merged 5 commits into from
Jun 11, 2024

Conversation

mike-hunhoff
Copy link
Collaborator

No description provided.

williballenthin
williballenthin approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@williballenthin williballenthin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small things, mainly descriptions, then ready to go!

host-interaction/process/create/create-process-on-linux.yml Outdated Show resolved Hide resolved
nursery/execute-syscall.yml Outdated Show resolved Hide resolved
nursery/truncate-file-on-linux.yml Show resolved Hide resolved
mr-tz
mr-tz reviewed Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, a few items to discuss inline

host-interaction/file-system/write/write-file-on-linux.yml Show resolved Hide resolved
host-interaction/file-system/write/write-file-on-linux.yml Show resolved Hide resolved
nursery/modify-api-blacklist-or-denylist-via-jni-on-android.yml Show resolved Hide resolved
@mike-hunhoff
Copy link
Collaborator Author

@williballenthin @mr-tz we're failing lints because aarch64 isn't introduced until https://github.com/mandiant/capa/tree/feat/1755. That means we can't merge this until the referenced PR is merged?

@williballenthin
Copy link
Collaborator

hm let's pull the aarch64 and android features into master now so that we can support these rules. I'm afraid of too many things getting blocked behind #1755

@mr-tz
Copy link
Collaborator

mr-tz commented Jun 7, 2024 •
edited
Loading

That means we can't merge this until the referenced PR is merged?

It may just be this commit: mandiant/capa@e1186c5 or we can take all the changes to capa/features/common.py.

@mike-hunhoff mike-hunhoff mentioned this pull request Jun 10, 2024
Closed
3 tasks
@williballenthin williballenthin mentioned this pull request Jun 11, 2024
Merged
3 tasks
@mike-hunhoff mike-hunhoff merged commit ea14b38 into master Jun 11, 2024
3 checks passed
@mike-hunhoff mike-hunhoff deleted the new/linux/android branch June 11, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williballenthin williballenthin williballenthin approved these changes

@mr-tz mr-tz mr-tz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mike-hunhoff @williballenthin @mr-tz