Merge pull request #1442 from Vector35/fix_bn_error

Check if caller.llil is None before accessing its properties
mandiant · Apr 12, 2023 · 6ba5b2b · 6ba5b2b
2 parents e9e06bb + dd207fb
commit 6ba5b2b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,9 @@
 
 ### Bug Fixes
 
+- extractor: avoid Binary Ninja exception when analyzing certain files #1441 @xusheng6 
+
+
 ### capa explorer IDA Pro plugin
 
 ### Development

diff --git a/capa/features/extractors/binja/function.py b/capa/features/extractors/binja/function.py
@@ -25,7 +25,7 @@ def extract_function_calls_to(fh: FunctionHandle):
         # Everything that is a code reference to the current function is considered a caller, which actually includes
         # many other references that are NOT a caller. For example, an instruction `push function_start` will also be
         # considered a caller to the function
-        if caller.llil.operation in [
+        if caller.llil is not None and caller.llil.operation in [
             LowLevelILOperation.LLIL_CALL,
             LowLevelILOperation.LLIL_CALL_STACK_ADJUST,
             LowLevelILOperation.LLIL_JUMP,