-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flare-capa is incompatible with flare-floss 3.1.0 #2053
Comments
see #2059 (comment) and #2059 (comment) |
It looks like one could change all the I'm not entirely sure yet how this interacts with building a wheel. |
That sounds like a good place to start, and if the versioning is still too strict, we can relax to 👍 |
If I build a wheel with the relaxed constraints in the |
However, the This is why my original suggestion was to have a separate project for the command line tool, as the |
In the workflow I imagine, the user does Agree that you'd need source code for this. And I think this is expected behavior. I don't think users will require the pinned environment often; I imagine this only to be for the PyInstaller build and tests in CI or anyone that wants to reproduce this. Do you envision other workflows that prefer the pinned environment? I suppose active dev. What else? |
I won't ever want the pinned environment myself. I had been assuming that you want people installing the wheel in order to use it as a command-line tool to have the the dependencies pinned. But, if you don't care about that, we've got a solution already. I'll make a PR for that for you today or tomorrow. |
I just pushed #2079 as a first attempt. I'm hoping that I got the |
To be clear about how I'm thinking about the pinned version: we want some way to be able to assert that the environment in which all tests pass (in CI) is the same that we distribute in the standalone exe (which is the primary distribution method). We also want to make it easy for devs to recreate this environment to triage test failures or other bug reports. I don't expect most capa library users to need the pinned environment. We think most dependencies should generally work following semver and we can bump min versions when there's a particular need. thanks @uckelman-sf for the initial PR! |
…2132) * relax pyproject dependency versions and introduce requirements.txt closes #2053 closes #2079 * pyproject: document dev/build profile dependency policies * changelog * doc: installation: describe requirements.txt usage * pyproject: don't use dnfile 0.15 yet --------- Co-authored-by: Moritz <mr-tz@users.noreply.github.com>
…andiant#2132) * relax pyproject dependency versions and introduce requirements.txt closes mandiant#2053 closes mandiant#2079 * pyproject: document dev/build profile dependency policies * changelog * doc: installation: describe requirements.txt usage * pyproject: don't use dnfile 0.15 yet --------- Co-authored-by: Moritz <mr-tz@users.noreply.github.com>
Description
flare-floss 3.1.0 requires pydantic 2.6.0. No released version of flare-capa permits using pydantic 2.6.0; therefore, the two current releases cannot be used together.
Steps to Reproduce
Minimal pyproject.toml:
Then:
Expected behavior:
flare-capa and flare-floss are installed.
Actual behavior:
Versions
Every version of capa.
Additional Information
The immediate problem could be solved by a release of flare-capa which uses pydantic 2.6.0. However, problems of this sort could be avoided by setting constraints for dependencies which are looser.
The text was updated successfully, but these errors were encountered: