Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter: use pydantic to validate rule metadata #1141

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

mike-hunhoff
Copy link
Collaborator

@mike-hunhoff mike-hunhoff commented Aug 11, 2022

addresses #1138

  • linter: update scripts/lint.py to validate rule metadata using pydantic
  • linter: fix rule count

see mandiant/capa-rules#606 for affected rules (41)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

@github-actions github-actions bot dismissed their stale review August 11, 2022 21:33

CHANGELOG updated or no update needed, thanks! 😄

@mike-hunhoff mike-hunhoff changed the title update scripts/lint.py to validate rule metadata using pydantic linter: use pydantic to validate rule metadata Aug 11, 2022
@mike-hunhoff mike-hunhoff marked this pull request as draft August 11, 2022 21:42
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far :)

@mike-hunhoff mike-hunhoff marked this pull request as ready for review August 12, 2022 13:53
@mike-hunhoff mike-hunhoff merged commit 449c64d into master Aug 12, 2022
@mike-hunhoff mike-hunhoff deleted the fix/1138 branch August 12, 2022 14:26
@r0ny123
Copy link

r0ny123 commented Aug 12, 2022

Would you guys release version with this update?

@mr-tz
Copy link
Collaborator

mr-tz commented Aug 15, 2022

Yes, we're working on that :)

mr-tz added a commit that referenced this pull request Aug 15, 2022
* update scripts/lint.py to validate rule metadata using pydantic (#1141)

* doc: v401

Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants