Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet: support property feature extraction #1168

Merged
merged 61 commits into from
Sep 9, 2022
Merged

dotnet: support property feature extraction #1168

merged 61 commits into from
Sep 9, 2022

Conversation

mike-hunhoff
Copy link
Collaborator

branched from #1122.

changes include

anushkavirgaonkar and others added 30 commits July 21, 2022 09:41
@anushkavirgaonkar
Add property feature extraction support for fields accessed directly …
1515ddb 
…using CIL instructions
@anushkavirgaonkar
Support property feature extraction
9fae150
@anushkavirgaonkar
Format code
f34c5ec
@anushkavirgaonkar
Remove common api and property references
387561d
@anushkavirgaonkar
Format code
3fb0ff7
@anushkavirgaonkar
Format code
70ae4a6
@anushkavirgaonkar
Revert "Format code"
dba77c1 
This reverts commit 70ae4a6.
@anushkavirgaonkar
Format code
9c76b04
@anushkavirgaonkar
Format code
564bb96
@anushkavirgaonkar
Format code
dbdd321
@anushkavirgaonkar @mike-hunhoff
Update capa/features/extractors/dnfile/helpers.py
8dc01f8 
Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
@anushkavirgaonkar @mike-hunhoff
Update capa/features/extractors/dnfile/insn.py
9d54ced 
Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
@anushkavirgaonkar @mike-hunhoff
Update capa/features/extractors/dnfile/insn.py
7a2e552 
Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
@anushkavirgaonkar @mike-hunhoff
Update capa/features/extractors/dnfile/insn.py
6c2d740 
Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
@anushkavirgaonkar
Fix replace method name logic
e25d494
@anushkavirgaonkar
Merge branch 'feature_property' of https://github.com/anushkavirgaonk…
9e624bd 
…ar/capa into feature_property
@anushkavirgaonkar
Cache properties/fields
bf1713d
@anushkavirgaonkar
Add comments for checks
ccb1aad
@anushkavirgaonkar
Remove return statement
7e24af5
@anushkavirgaonkar @mike-hunhoff
Update capa/features/extractors/dnfile/insn.py
db8f1b2 
Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
@anushkavirgaonkar @mike-hunhoff
Update capa/features/extractors/dnfile/insn.py
02a2d2c 
Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
@anushkavirgaonkar @mike-hunhoff
Update capa/features/extractors/dnfile/helpers.py
adfd672 
Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
@anushkavirgaonkar
Fix get_dotnet_properties return type
d35cd47
@anushkavirgaonkar
Add tests for property features
45a6e1b
@anushkavirgaonkar
Fix file path
8cc6069
@anushkavirgaonkar
Add constants for metadata table numbers
20928f1
@anushkavirgaonkar
Add tests covering different methodsfor referencing properties
54d29cd
@anushkavirgaonkar
Add test
ffbf038
@anushkavirgaonkar
remove test
25e8226
@anushkavirgaonkar
Update dnfile version
c84aeb1
This was referenced Sep 9, 2022
Closed
Closed
mr-tz
mr-tz reviewed Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for updating. Just a few minor comments (no stoppers).

capa/features/common.py Show resolved Hide resolved
capa/features/extractors/dnfile/helpers.py Outdated Show resolved Hide resolved
capa/features/extractors/dnfile/insn.py Outdated Show resolved Hide resolved
mike-hunhoff and others added 12 commits September 9, 2022 08:35
@mike-hunhoff @mr-tz
Update capa/features/common.py
97fd697 
Co-authored-by: Moritz <mr-tz@users.noreply.github.com>
@mike-hunhoff @williballenthin
Update capa/features/extractors/dnfile/insn.py
dc27b28 
Co-authored-by: Willi Ballenthin <willi.ballenthin@gmail.com>
@mike-hunhoff @williballenthin
Update capa/features/extractors/dnfile/insn.py
e3b1362 
Co-authored-by: Willi Ballenthin <willi.ballenthin@gmail.com>
@mike-hunhoff @williballenthin
Update capa/features/extractors/dnfile/insn.py
1cdb699 
Co-authored-by: Willi Ballenthin <willi.ballenthin@gmail.com>
@mike-hunhoff @williballenthin
Update capa/features/extractors/dnfile/insn.py
f7b2b57 
Co-authored-by: Willi Ballenthin <willi.ballenthin@gmail.com>
@mike-hunhoff @williballenthin
Update capa/features/extractors/dnfile/insn.py
12947a3 
Co-authored-by: Willi Ballenthin <willi.ballenthin@gmail.com>
@mike-hunhoff @williballenthin
Update capa/features/extractors/dnfile/insn.py
39408f6 
Co-authored-by: Willi Ballenthin <willi.ballenthin@gmail.com>
@mike-hunhoff
PR feedback updates
585d764
@mike-hunhoff
fix formatting
ce36c08
@mike-hunhoff
fix vverbose rendering and add tests
1960408
@mike-hunhoff
subclassing feature access
99cb5ab
@mike-hunhoff
Update common.py
8fec752
@mike-hunhoff mike-hunhoff merged commit 3c1cd67 into master Sep 9, 2022
@mike-hunhoff mike-hunhoff deleted the feature_property_updates branch September 9, 2022 18:09
@mike-hunhoff mike-hunhoff mentioned this pull request Sep 12, 2022
Closed
@mr-tz mr-tz mentioned this pull request Sep 13, 2022
Open
4 tasks
@mike-hunhoff mike-hunhoff mentioned this pull request Sep 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-tz mr-tz mr-tz left review comments

@williballenthin williballenthin williballenthin left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mike-hunhoff @williballenthin @mr-tz @anushkavirgaonkar