Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghidra: Function Feature Extraction #1597

Merged
merged 7 commits into from
Jul 12, 2023
Merged

Ghidra: Function Feature Extraction #1597

merged 7 commits into from
Jul 12, 2023

Conversation

colton-gabertan
Copy link
Collaborator

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

Implements #1509 Ghidra Function Feature Extraction

@colton-gabertan colton-gabertan self-assigned this Jul 8, 2023
@colton-gabertan colton-gabertan changed the title Ghidra func feats 1509 Ghidra: Function Feature Extraction Jul 8, 2023
mike-hunhoff
mike-hunhoff requested changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@mike-hunhoff mike-hunhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good progress @colton-gabertan ! I've left comments for your review.

capa/features/extractors/ghidra/function.py Outdated Show resolved Hide resolved
capa/features/extractors/ghidra/function.py Show resolved Hide resolved
capa/features/extractors/ghidra/function.py Outdated Show resolved Hide resolved
capa/features/extractors/ghidra/function.py Outdated Show resolved Hide resolved
capa/features/extractors/ghidra/helpers.py Outdated Show resolved Hide resolved
capa/features/extractors/ghidra/helpers.py Show resolved Hide resolved
@mike-hunhoff mike-hunhoff added ghidra Related to Ghidra integration gsoc Work related to Google Summer of Code project. labels Jul 10, 2023
@mike-hunhoff
Copy link
Collaborator

@colton-gabertan do we know why a majority of the CI workflow is being cancelled?

@mike-hunhoff
Copy link
Collaborator

@colton-gabertan do we know why a majority of the CI workflow is being cancelled?

nvm, looks like a second run fixed it! LGTM 🚀

@mike-hunhoff mike-hunhoff merged commit 97c2005 into backend-ghidra Jul 12, 2023
@mike-hunhoff mike-hunhoff deleted the ghidra-func-feats-1509 branch July 12, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-hunhoff mike-hunhoff Awaiting requested review from mike-hunhoff

Assignees

@colton-gabertan colton-gabertan

Labels
ghidra Related to Ghidra integration gsoc Work related to Google Summer of Code project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colton-gabertan @mike-hunhoff