-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop script to highlight features unused during matching #1683
Develop script to highlight features unused during matching #1683
Conversation
Used show_features.py script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see recommendations inline. most are type hint updates. moving the get_all_features
routine to Rule
will help cut down on the logic duplicated across a few scripts, which is nice.
as for the output, would you:
- highlight/color only the content between the parentheses, and
- order the output from least to most common
all in all, this is neat, thank you @Aayush-Goel-04!
would you please also add a test showing the invocation of the script, like we do here: https://github.com/mandiant/capa/blob/master/tests/test_scripts.py#L45 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only noting small things I've noticed, overall this is great
Co-authored-by: Moritz <mr-tz@users.noreply.github.com>
please address test failures on python 3.8 (maybe syntax/typing related?). |
|
@williballenthin @mr-tz all tests are passing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline tweaks, then we'll be ready to merge.
Co-authored-by: Willi Ballenthin <wballenthin@google.com>
Co-authored-by: Willi Ballenthin <wballenthin@google.com>
Done, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @Aayush-Goel-04 !
closes #331
Logic Used
scripts/show_features.py
.Checklist