Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dynamic scopes to capa2fmt #1758

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Add dynamic scopes to capa2fmt #1758

merged 5 commits into from
Aug 24, 2023

Conversation

yelhamer
Copy link
Collaborator

This PR modifies the format of the yara rules' meta according to the new scopes format.

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

mr-tz
mr-tz reviewed Aug 24, 2023
View reviewed changes
tests/test_scripts.py Outdated Show resolved Hide resolved
mr-tz
mr-tz reviewed Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruff is complaining:

 tests/test_main.py:14:8: F401 [*] `pytest` imported but unused
Found 1 error.
[*] 1 potentially fixable with the --fix option.

@yelhamer @mr-tz
Update tests/test_scripts.py
d66f834 
Co-authored-by: Moritz <mr-tz@users.noreply.github.com>
@yelhamer yelhamer merged commit acd3a30 into mandiant:dynamic-feature-extraction Aug 24, 2023
@yelhamer yelhamer deleted the fix-cape2fmt branch August 24, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-tz mr-tz mr-tz left review comments

@williballenthin williballenthin williballenthin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yelhamer @williballenthin @mr-tz