-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a citation file to capa #2018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased)
section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
Co-authored-by: Moritz <mr-tz@users.noreply.github.com>
Co-authored-by: Moritz <mr-tz@users.noreply.github.com>
Co-authored-by: Moritz <mr-tz@users.noreply.github.com>
Co-authored-by: Moritz <mr-tz@users.noreply.github.com>
CHANGELOG updated or no update needed, thanks! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add empty line at EOF and indent name, please, then should be good to go, thank you
Co-authored-by: Moritz <mr-tz@users.noreply.github.com>
Co-authored-by: Moritz <mr-tz@users.noreply.github.com>
thanks to this I went down the rabbit hole behind the importance of a newline at the end of a file and how it causes issues if we don't add them , learnt something new pretty sweet!! |
@mr-tz would the above changes be fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Have added a citation file for capa, presently it's under the name "The FLARE Team", would require changes If team believes it should be substituted with the names of the core team members.
it closes issue #1929
Checklist