support more report formats #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williballenthin
approved these changes
Mar 28, 2024
| @@ -398,7 +398,7 @@ class CapeReport(FlexibleModel): | |||
| behavior: Behavior | |||
|
|
|||
| # post-processed results: payloads and extracted configs | |||
| CAPE: Optional[Cape] = None | |||
| CAPE: Optional[Union[Cape, List]] = None | |||
There was a problem hiding this comment.
In the provided sample report it's an empty list and that's why it fails
...
"CAPE": [],
...There was a problem hiding this comment.
if there's a better definition for this case, let's use that
There was a problem hiding this comment.
looks like maybe List[typing.Never] via https://stackoverflow.com/questions/45264194/why-does-pycharm-not-accept-my-type-hint-for-an-empty-list#comment135535258_73323753
There was a problem hiding this comment.
that didn't fly in my short testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2035
Checklist