improve handling _ prefix added to library functions as compile/link artifact #924
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
github-actions
bot
dismissed
their stale review
CHANGELOG updated or no update needed, thanks! 😄
mike-hunhoff
changed the title
| @@ -152,6 +152,8 @@ def extract_file_function_names(): | |||
| if idaapi.get_func(ea).flags & idaapi.FUNC_LIB: | |||
| name = idaapi.get_name(ea) | |||
| yield FunctionName(name), ea | |||
| if name.startswith("_"): | |||
| yield FunctionName(name[1:]), ea | |||
There was a problem hiding this comment.
name[1:] vs name.lstrip("_")
one removes all prefixes, the other removes exactly one. can you confirm a final time this is what we want?
also, recommend including a comment here explaining what we're handling.
There was a problem hiding this comment.
I'm basing this updated logic on how functions are defined by MSDN. We want to remove exactly one _ as there are functions defined with a leading _ e.g. _wfopen (https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/fopen-wfopen?view=msvc-170). In the case of _wfopen the linker may prefix as __wfopen. Using the logic mentioned here we would emit both _wfopen and __wfopen. wfopen is not defined by MSDN therefore it should not be emitted.
There was a problem hiding this comment.
This assumes the _ prefix is always added (my understanding).
Co-authored-by: Willi Ballenthin <willi.ballenthin@gmail.com>
Co-authored-by: Willi Ballenthin <willi.ballenthin@gmail.com>
Co-authored-by: Willi Ballenthin <willi.ballenthin@gmail.com>
Co-authored-by: Willi Ballenthin <willi.ballenthin@gmail.com>
fixes #923