Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove /x32 and /x64 flavors of number and offset features #961

Merged
merged 19 commits into from
Apr 6, 2022
Merged

remove /x32 and /x64 flavors of number and offset features #961

merged 19 commits into from
Apr 6, 2022

Conversation

williballenthin
Copy link
Collaborator

@williballenthin williballenthin commented Apr 5, 2022 •
edited
Loading

closes #932
closes #962
closes #964

changes:

  • removes /x32 and /x64 from number and offset features
  • capa now accepts multiple --rules parameters
  • vverbose mode now shows all rule matches (lib, malware-category, etc.)

TODO

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@williballenthin williballenthin added the breaking-change introduces a breaking change that should be released in a major version label Apr 5, 2022
@williballenthin williballenthin added this to the 4.0.0 milestone Apr 5, 2022
@williballenthin williballenthin marked this pull request as ready for review April 5, 2022 16:38
@williballenthin
Copy link
Collaborator Author

i suppose we should wait for rule updates so tests pass here. then merge.

@williballenthin williballenthin marked this pull request as draft April 5, 2022 16:44
@williballenthin
Copy link
Collaborator Author

image

locally, tests pass, except for those that rely on parsing capa-rules

@williballenthin williballenthin mentioned this pull request Apr 5, 2022
Merged
mr-tz
mr-tz approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

mike-hunhoff
mike-hunhoff approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@mike-hunhoff mike-hunhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@williballenthin
Copy link
Collaborator Author

tests passing 💥

@williballenthin williballenthin marked this pull request as ready for review April 6, 2022 18:57
@williballenthin williballenthin merged commit 55a5d10 into master Apr 6, 2022
@williballenthin williballenthin deleted the feature-remove-flavors branch April 6, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-hunhoff mike-hunhoff mike-hunhoff approved these changes

@mr-tz mr-tz mr-tz approved these changes

Assignees
No one assigned
Labels
breaking-change introduces a breaking change that should be released in a major version
Projects
None yet
Milestone
4.0.0
3 participants
@williballenthin @mr-tz @mike-hunhoff