Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needed changes in light of the creation of v2 #45

Open
jessp01 opened this issue Sep 23, 2023 · 11 comments
Open

Needed changes in light of the creation of v2 #45

jessp01 opened this issue Sep 23, 2023 · 11 comments

Comments

@jessp01
Copy link
Collaborator

jessp01 commented Sep 23, 2023

Hi @mandolyte ,

Since we're now on v2, some structure changes are required as, when one runs:

go install github.com/mandolyte/mdtopdf/cmd/md2pdf@latest

The received version is v1.5.3, not v2.2.1.

When trying to explicitly install v2.2.1:

$ go install github.com/mandolyte/mdtopdf/cmd/md2pdf@v2.2.1

One would get this message:

go: github.com/mandolyte/mdtopdf/cmd/md2pdf@v2.2.1: github.com/mandolyte/mdtopdf@v2.2.1: invalid version: module contains a go.mod file, so module path must match major version ("github.com/mandolyte/mdtopdf/v2")

Please see https://go.dev/blog/v2-go-modules

Happy to help with the restructure if you'd like.

Cheers,

@mandolyte
Copy link
Owner

mandolyte commented Sep 25, 2023

@jessp01 I have a counter proposal... while I love to code and this and other projects were done after I retired, I don't quite see myself spending as much time coding going forward. I also just finished a 3 year stint of working for a non-profit doing web apps with JavaScript. And now my kids have moved to Texas and England. I don't think I'll be doing much coding even tho I enjoy it.

So my counter proposal is this: would you be willing to take over this package? Thanks for your interest and energy!

@jessp01
Copy link
Collaborator Author

jessp01 commented Sep 25, 2023

Hi @mandolyte ,

I also just finished a 3 year stint of working for a non-profit doing web apps with JavaScript.

Laudable, indeed.

And now my kids have moved to Texas and England I don't think I'll be doing much coding even tho I enjoy it.

Hope you enjoy your travels to both (I live in England, myself) and your retirement in general.

Happy to take over if you'd like:)

@mandolyte
Copy link
Owner

@jessp01 I think I can just transfer the repo to you. But thought I'd make sure that was the best approach. What do you recommend?

@jessp01
Copy link
Collaborator Author

jessp01 commented Sep 26, 2023

Hi @mandolyte ,

Yes, I think that'd be fine:)

@mandolyte
Copy link
Owner

I got an error. Looks like you need to (re)move your repo with same name...
image

@jessp01
Copy link
Collaborator Author

jessp01 commented Sep 26, 2023

Ah, I thought you'd just grant my user write privileges on the existing repo, or in other words, set me up as a "collaborator":)
https://github.com/mandolyte/mdtopdf/settings/access

That way, you could still co-maintain it with me whenever you're so inclined and we needn't redirect from https://github.com/mandolyte/mdtopdf.

@mandolyte
Copy link
Owner

I see. That makes sense. I have added you. You should have an invite.

@jessp01
Copy link
Collaborator Author

jessp01 commented Sep 26, 2023

Happily accepted and just merged my own pull :)
Thanks, @mandolyte. Enjoy your retirement!

jessp01 added a commit that referenced this issue Nov 17, 2023
@mandolyte
Copy link
Owner

@jessp01 I noticed some new issues. Will you be able to take a look? BTW, I am in England also until April (near London). Warmer, but wetter than Cincinnati :-)

@jessp01
Copy link
Collaborator Author

jessp01 commented Feb 15, 2024

Hi @mandolyte ,

Hope you're well. I can only see two issues from the same user pertaining to the use of the Noto Sans font. I've posted a comment on these. Were you referring to those or something else?

PS
Enjoy your time in England:)

@mandolyte
Copy link
Owner

mandolyte commented Feb 15, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants