Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reset keepalive timer on received message #58

Merged
merged 1 commit into from
May 19, 2021
Merged

Don't reset keepalive timer on received message #58

merged 1 commit into from
May 19, 2021

Conversation

droserasprout
Copy link
Contributor

Resetting timer on received message leads to server closing connection due to inactivity. Protocol specs mention only sent messages as a reason to skip ping:

A Ping is only sent if the interval has elapsed without a message being sent.

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #58 (37d835b) into main (13aaa64) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   94.11%   94.06%   -0.05%     
==========================================
  Files          34       34              
  Lines        1274     1264      -10     
==========================================
- Hits         1199     1189      -10     
  Misses         75       75              
Impacted Files Coverage Δ
...lrcore/transport/websockets/websocket_transport.py 83.66% <ø> (-0.11%) ⬇️
signalrcore/protocol/base_hub_protocol.py 92.00% <0.00%> (-0.16%) ⬇️
signalrcore/helpers.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13aaa64...37d835b. Read the comment docs.

@jdeksup
Copy link

jdeksup commented May 12, 2021

Please merge this PR. We get a connection close from the serveer, just after the server send several events.

@mandrewcito mandrewcito merged commit 44a1ae6 into mandrewcito:main May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants