Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary forward slash #11

Merged
merged 1 commit into from
Nov 1, 2019
Merged

fix: remove unnecessary forward slash #11

merged 1 commit into from
Nov 1, 2019

Conversation

bnb
Copy link
Contributor

@bnb bnb commented Oct 22, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Has a / after the GitHub URL

Issue Number: N/A

What is the new behavior?

Does not have a / after the GItHub URL

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@bnb bnb requested a review from manekinekko as a code owner October 22, 2019 13:25
glaucia86
glaucia86 approved these changes Oct 23, 2019
View reviewed changes
Copy link

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manekinekko manekinekko merged commit 7843b8f into manekinekko:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manekinekko manekinekko manekinekko approved these changes

@glaucia86 glaucia86 glaucia86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnb @glaucia86 @manekinekko