Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal schedule support #53

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

mintybayleaf
Copy link
Contributor

Changes

Added support for Temporal's Schedule feature to this SDK. My company has been using these wrappers we wrote locally for quite a while and they have been battle tested. I thought it would be good to give back to the community.

Temporal Java SDK

Schedule How-To

  • Implement core builders for Schedule, SchedulePolicy, ScheduleSpec, ScheduleState, ScheduleActionStartWorkflow, and ScheduleOptions in internal/schedule.clj
  • Implement ScheduleClient and associated operations in client/schedule.clj
  • Move grpc related stub code to internal/grpc.clj so both clients can share
  • Move workflow options back to internal/workflow.clj so both clients can share
  • Move client options to client/options.clj
  • Update test/types.clj with new Schedule related builder tests
  • Create test/schedule.clj with new Schedule related operation tests
  • Update the doc/clients.md to include ScheduleClient documentation

Review Checklist

  • Performed a self-review of my code
  • Added thorough tests
  • Run the documentation examples in the REPL locally against Temporal

Issue ticket number and link

N/A

Bailey Kocin added 2 commits March 11, 2024 17:29
Signed-off-by: Bailey Kocin <bkocin@crossbeam.com>
Signed-off-by: Bailey Kocin <bkocin@crossbeam.com>
Bailey Kocin added 2 commits March 13, 2024 12:16
Signed-off-by: Bailey Kocin <bkocin@crossbeam.com>
Signed-off-by: Bailey Kocin <bkocin@crossbeam.com>
Copy link
Contributor

@ghaskins ghaskins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@ghaskins ghaskins merged commit d54ca23 into manetu:master Mar 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants