Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add child workflow implementation #58

Merged
merged 8 commits into from
May 19, 2024

Conversation

mintybayleaf
Copy link
Contributor

Add the implementation for Child Workflows to the Temporal Clojure SDK

Why?

Child Workflows are a key feature in separating out Workflow execution histories and physically preventing two of the same workflow execution from being spawned if uniqueness needs to be guaranteed.

What?

  • I reused the invoke logic for the activities and added an invoke function to the workflow namespace
  • I added a internal/child_workflows for building the ChildWorkflowOptions
  • Added tests for regular child workflows, concurrent parent/child workflows, and async activities inside child workflows
  • I added a documentation page for child workflows.

How?

For more information look at these links:

TODOS: Test against a live Temporal cluster more

Let me know if you have any questions and concerns

Bailey Kocin added 8 commits May 16, 2024 16:33
Signed-off-by: Bailey Kocin <bkocin@crossbeam.com>
Signed-off-by: Bailey Kocin <bkocin@crossbeam.com>
Signed-off-by: Bailey Kocin <bkocin@crossbeam.com>
Signed-off-by: Bailey Kocin <bkocin@crossbeam.com>
Signed-off-by: Bailey Kocin <bkocin@crossbeam.com>
Signed-off-by: Bailey Kocin <bkocin@crossbeam.com>
Signed-off-by: Bailey Kocin <bkocin@crossbeam.com>
Signed-off-by: Bailey Kocin <bkocin@crossbeam.com>
@mintybayleaf mintybayleaf marked this pull request as ready for review May 17, 2024 00:40
@ghaskins
Copy link
Contributor

Thank you!

@ghaskins ghaskins merged commit 6c66ae1 into manetu:master May 19, 2024
2 checks passed
ghaskins added a commit that referenced this pull request May 21, 2024
Changes since v0.20.2
---------------------
a47a2eb Update deps
63d5ee2 Update documentation for **stable** status
6c66ae1 add child workflow implementation (#58)
9b75d8b update documentation for all-settled
a7bab0b optimize the number of arrays used
9e3f242 add better tests
2693986 rename to all-settled
0f6e80f add new allSettled handler

Signed-off-by: Greg Haskins <greg@manetu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants