Use temporal-shaded to avoid protobuf version mismatch #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelipeCortez
force-pushed
the
fix-cljdoc-by-switching-to-temporal-shaded
branch
2 times, most recently
from
8dd77b3 to
cdb5c9f
Compare
Signed-off-by: Felipe Cortez <github@felipecortez.net>
FelipeCortez
force-pushed
the
fix-cljdoc-by-switching-to-temporal-shaded
branch
from
cdb5c9f to
07b3161
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cljdoc API import seems to have been failing since 1.3.0 because of a protobuf version mismatch. This PR switches the Temporal Java SDK to the shaded version. Analysis was tested locally with
clojure -Ttools install io.github.cljdoc/cljdoc-analyzer '{:git/tag "RELEASE"}' :as cljdoc && lein jar && lein pom && clojure -Tcljdoc analyze-localand ran successfully after the change.