decreaseExpirationBySec is being used as miliseconds

[wawyed]

Describe the bug
The variable name and documentation imply that this is use as seconds but the comparisons in the code are against milliseconds values.

Use cases:

angular-oauth2-oidc/projects/lib/src/oauth-service.ts

Line 2427 in be84e3d

parseInt(expiresAt, 10) - this.decreaseExpirationBySec <

angular-oauth2-oidc/projects/lib/src/oauth-service.ts

Line 2271 in be84e3d

expiresAtMSec + clockSkewInMSec - this.decreaseExpirationBySec <= now

We either fix the code or documentation. Probably less breaking change to fix the two usages.

[eddyuk]

Just spent few hours and @wawyed is completely right

[ewolfman]

hi @manfredsteyer, it looks like this should have been ms and not seconds. What do you think?