Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider normalizing spacing and other code style issues #677

Closed
jeroenheijmans opened this issue Nov 20, 2019 · 1 comment
Closed

Consider normalizing spacing and other code style issues #677

jeroenheijmans opened this issue Nov 20, 2019 · 1 comment

Comments

@jeroenheijmans
Copy link
Collaborator

Many PRs seem to include changes to whitespace, probably because VSCode plugins for many folks auto-fix files (based on the given config) when they only update one or two lines. For example in my own recent PR many whitespace changes were silently made by VSCode (with only relevant plugins being TSLint and EditorConfig) based on the configs.

Please consider normalizing all spaces and other syntactic things (e.g. trailing comma's and so forth) to match the configs and linting files in the repo. This should prevent future PRs from attracting too many distracting changes.

@manfredsteyer
Copy link
Owner

Great idea. Just added prettier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants