Use preventClearHashAfterLogin consistently #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox will show annoying behavior for setting location.hash to an empty string if it already is empty: it refreshes the page or scrolls to the top. The preventClearHashAfterLogin option is passed down to functions to prevent this behavior when it's not needed (e.g. during the results of a silent refresh). However, that option wasn't checked for in a consistent manner. This commit fixes that. Fixes manfredsteyer#493
|
over 20 pull requests, yet the last commit on master is 4 months ago. Is the project actually doing "good"? Or is there a more active fork out there? |
|
The maintainer typically does a major release whenever a major Angular release comes out, often with a few minors to follow-up things - as opposed to frequent updates. He's expressed (can't find a link atm) the intention to bring out updates short after ng9 due to come out soonish. I don't know of any forks with more frequent updates, but I guess it's moderately easy to create a fork yourself if you need a subset of PRs faster than that. Finally, if you want a more frequent update schedule, I think that this other similar library can also be used. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox will show annoying behavior for setting location.hash to an empty string if it already is empty: it refreshes the page or scrolls to the top.
The preventClearHashAfterLogin option is passed down to functions to prevent this behavior when it's not needed (e.g. during the results of a silent refresh). However, that option wasn't checked for in a consistent manner. This commit fixes that.
Fixes #493