-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 9 upgrade #718
Angular 9 upgrade #718
Conversation
Good practice, but also needed to run e2e tests with the latest version of ChromeDriver. In addition, it fixes security vulns (handlebars).
"@angular/common": ">=9.0.0", | ||
"@angular/core": ">=9.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will exclude older angular versions. should probably be as it was unless the new update introduces breaking changes for older versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True! I did do it intentionally but without too much confidence I guess: since there were so many migrations and compiler changes in NG9 (more so than 7 and 8), and since there's limited capacity/enthusiasm in this lib's community to support mixing newer versions of the lib with older versions of Angular.... I guessed that this change may be a good one.
But I suppose we can bring it down again, and consider using v9 of the lib with <v9 angular versions a "no warranty" thing?
Leaving this choice up to Manfred I think.
Hi Much appreciate for the effort to support angular 9. Are you going to include this fix in next release? Our team is going to upgrade to angular 9 soon. I am just wondering if you have a timeframe for next release? Thanks |
Thanks! |
Fixes #717
Steps taken:
9.0.0-RC1
- I presume we'd want to include other PRs too if we're releasing a new version?Not done: