Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 9 upgrade #718

Merged

Conversation

jeroenheijmans
Copy link
Collaborator

Fixes #717

Steps taken:

  1. Update to latest Angular 8 stuff
  2. Update to Angular 9 with the upgrade cli commands
  3. Tweak small things that didn't go perfect during upgrade
  4. Update all devDependencies (for one to fix security vulnerabilities)
  5. Tweak the readme and change log slightly
  6. Bump the version to 9.0.0-RC1 - I presume we'd want to include other PRs too if we're releasing a new version?

Not done:

  • Rebuilding (and committing) the docs. This is awkward on a Windows machine, as it touches all files and affects the newlines. Didn't seem needed anyways as the docs only need to be regenerated upon actual release?

Comment on lines +13 to +14
"@angular/common": ">=9.0.0",
"@angular/core": ">=9.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will exclude older angular versions. should probably be as it was unless the new update introduces breaking changes for older versions

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True! I did do it intentionally but without too much confidence I guess: since there were so many migrations and compiler changes in NG9 (more so than 7 and 8), and since there's limited capacity/enthusiasm in this lib's community to support mixing newer versions of the lib with older versions of Angular.... I guessed that this change may be a good one.

But I suppose we can bring it down again, and consider using v9 of the lib with <v9 angular versions a "no warranty" thing?

Leaving this choice up to Manfred I think.

@yukund
Copy link

yukund commented Feb 12, 2020

Hi

Much appreciate for the effort to support angular 9.

Are you going to include this fix in next release?

Our team is going to upgrade to angular 9 soon. I am just wondering if you have a timeframe for next release?

Thanks

@manfredsteyer manfredsteyer merged commit 74666bf into manfredsteyer:master Mar 2, 2020
@manfredsteyer
Copy link
Owner

Thanks!

@jeroenheijmans jeroenheijmans deleted the angular-9-upgrade branch March 2, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 9 upgrade
4 participants