Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed not working silent refresh when using 'code' #735

Merged
merged 1 commit into from
Mar 21, 2020

Conversation

ErazerBrecht
Copy link
Contributor

window.location.search is "" when using the iframe.
The querySource seems to have the correct value

A fix for #600

window.location.search is "" when using the iframe.
The querySource seems to have the correct value
@jeroenheijmans
Copy link
Collaborator

Wow, amazing! Is that truly all that is needed to fix the issue, while keeping things working for other flows and code paths?! 😮 If so: fantastic! 💖

@ErazerBrecht
Copy link
Contributor Author

ErazerBrecht commented Mar 5, 2020

I tested it on my own code, it seems to do the job ;)
I also suspect this is an incorrect merge in the latest release.
Because the variable is not used while it's clearly meant to be used for that purpose.

@jprokop-va
Copy link

jprokop-va commented Mar 5, 2020

I came to the same fix and it seems to make sense for both paths.

@manfredsteyer
Copy link
Owner

That's great. Thanks! I'll make a 9.1 release ready soon.

@manfredsteyer
Copy link
Owner

Wow, I had no idea that it would be THAT easy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants