Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HeanCMS Template and websites #397

Open
wants to merge 56 commits into
base: master
Choose a base branch
from
Open

Add HeanCMS Template and websites #397

wants to merge 56 commits into from

Conversation

MikeZeDev
Copy link
Contributor

@MikeZeDev MikeZeDev commented Dec 11, 2023 •
edited
Loading

No description provided.

@ronny1982
Copy link
Contributor

Novels shall not be handled as Manga, similar to Anime they should have their dedicated types.
However, there is no concept yet how to process Novels as the current focus is on Anime support.

@MikeZeDev
Copy link
Contributor Author

MikeZeDev commented Dec 12, 2023 •
edited
Loading

I totally agree. That said

  1. This template is interesting as the API can gives us the html of the novel chapter directly.
  2. Because the current focus is anime doesnt mean there can be a basic novel support live we had before in the meantime.

Would it be ok to disable Novel support inside and submit it? I think there is no harm letting it like this.

@MikeZeDev MikeZeDev marked this pull request as ready for review October 13, 2024 07:53
@MikeZeDev MikeZeDev changed the title Add HeanCMS decorator and websites Add HeanCMS Template and websites Oct 13, 2024
ronny1982
ronny1982 reviewed Nov 2, 2024
View reviewed changes
Copy link
Contributor

@ronny1982 ronny1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are only 3 websites which are related and would benefit from a decorator.
May consider using template or base class approach instead.

@MikeZeDev
Copy link
Contributor Author

There are only 3 websites which are related and would benefit from a decorator. May consider using template or base class approach instead.

Hu? its already the case boss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronny1982 ronny1982 ronny1982 left review comments

Assignees
No one assigned
Labels
Website Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeZeDev @ronny1982