Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle as linux tar #714

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Robonau
Copy link

@Robonau Robonau commented Jul 29, 2024

as the title says its some bundles for Linux tar

made them not portable because they will be more useful as not portable in regards to external builds
(like the AURs PKGBUILD)

the icon and desktop entry files should probably not be in the tar and instead in a separate linux-assets.tar.gz

i don't plan to maintain this, was just something i wanted to do cause someone asked for a linux release in the discord
though its almost a copy of the windows portable zip so it shouldn't be to bad

@ronny1982
Copy link
Contributor

ronny1982 commented Aug 4, 2024

Tested Environment:

  • Dell Inspiron 15
  • Intel i3 11th Generation (4-Core)
  • 8 GB Ram
  • 256 GB SSD
  • Kubuntu 24.04. (64-Bit)

NW 64-Bit Build

⚠️ Crashed as soon as the UI was doing some more render intensive work e.g., MangaDex/Berserk chapter list.
nw.log

NW 32-Bit Build

⚠️ Could not be started on the 64-Bit system (probably because dependencies to i386 were missing).

Electron 64-Bit Build

❌ Could not be started, probably because some files in the bundle needs certain permissions before getting bundled in a tar.gz archive.
electron.log

Electron 32-Bit Build

⚠️ There was no related archive after the bundle operation.

Electron ARM Builds

ℹ️ Could not be tested due to lack of hardware with corresponding architecture.

@ronny1982
Copy link
Contributor

When deploying tar.gz archives it might be useful for the consumer to know what to do, so providing instructions may help e.g., as readme inside of the archive (a veteran would probably run configure, make and make install which will not work with this archive).

@ronny1982
Copy link
Contributor

The hakunkeo.desktop file is more like a template and not of much use as is. Maybe it would be better to not include this file at all?

Copy link
Contributor

@ronny1982 ronny1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the topic needs some more honing and testing on linux platforms before an NW or Electron canary bundle can be released to the public

@Robonau
Copy link
Author

Robonau commented Aug 11, 2024

yea, i have no clue what im doing tbh, i just wanted a build that worked on linux
and this worked for me
feel free to close if u don't want it, im not gonna continue working on it as i said in my initial message

@MikeZeDev MikeZeDev added the enhancement New feature or request label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants