Blacklist facebook comments plugin

[Sheepux]

Solves issue with mangahere having random long timeouts

(node:20188) electron: Failed to load URL: https://www.facebook.com/v2.10/plugins/comments.php?app_id=250769461611065&channel=https%3A%2F%2Fstaticxx.facebook.com%2Fx%2Fconnect%2Fxd_arbiter%2F%3Fversion%3D46%23cb%3Dfaa6c354a43a87de7%26domain%3Dwww.mangahere.cc%26is_canvas%3Dfalse%26origin%3Dhttps%253A%252F%252Fwww.mangahere.cc%252Ffc0a582566ff38cf5%26relation%3Dparent.parent&container_width=0&height=100&href=http%3A%2F%2Fwww.mangahere.co%2Fmanga%2Fvigilante_boku_no_hero_academia_illegals%2Fc123%2F1.html&locale=en_US&sdk=joey&version=v2.10&width=702 with error: ERR_BLOCKED_BY_RESPONSE

[MikeZeDev]

you might want to blacklist non www domains too, and perhaps fbcdn ?

[Sheepux]

you might want to blacklist non www domains too,

Check the MR ;)

    '*://*.facebook.com/*',
    '*://*.facebook.net/*',

and perhaps fbcdn ?

I don't know the impact, that'll be a topic for another time.

I just did this PR in case you or Ronny had issues in mind if banning such domains would break things (connectors that would stop working)

[MikeZeDev]

AFAIK, those pattern will filter

https://anything.facebook.com/anything

but not

https://facebook.com/anything

Like i've said you may want to filter it too ^^

[Sheepux]

Don't need to unless proven otherwise

[ronny1982]

Will this prevent users from interactive login on manga websites via facebook?

[Sheepux]

Didn't think about that !
I don't have facebook/connector, can someone test it ?

[Sheepux]

Or should i limit the scope to
*://www.facebook.com/*/plugins/comments.php*

[MikeZeDev]

I think limiting to the comment plugin may be a viable solution.

[ronny1982]

Probably safer for now