Add Priority field for MX record #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I'm pretty sure the test failure is just because of my slightly janky GH Actions setup) Looks good to me! Thanks a lot! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to matschundbrei/cloudns-go#1 and matschundbrei/cloudns-go#2
Priority field is required for MX records https://www.cloudns.net/wiki/article/58/
CloudDNS API doesn't allow creating and updating MX records without providing Priority field.
Priority is also used in SRV record, but SRV also requires adding other fields to work.
I'm not familiar with SRV records, so I didn't try adding support for them.