Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue with pause/play button in Grindplayer #326

Closed
zuzzurro opened this issue Jun 30, 2015 · 5 comments
Closed

Possible issue with pause/play button in Grindplayer #326

zuzzurro opened this issue Jun 30, 2015 · 5 comments

Comments

@zuzzurro
Copy link

When I open this page:

http://www.flashls.org/latest/examples/osmf/GrindPlayer.html

The player start in play mode, but the play/pause button shows the wrong state (it still shows the play icon and not the pause icon). This means also that the first time I click on the button, the player tries to start again, and from that moment onward it shows the right state.

@mangui
Copy link
Owner

mangui commented Jul 7, 2015

indeed, will check.
knowing when this regression has been introduced would speed up the investigation.

@zuzzurro
Copy link
Author

OK, as it seemed like a simple enough issue to test, I tried bisecting it. Here is the answer:

% git bisect bad
20f771a is the first bad commit
commit 20f771a
Author: mangui g.du.pontavice@gmail.com
Date: Tue Mar 10 15:04:55 2015 +0100

update swf/swc
related to #204

:040000 040000 3653934b27572000e23b5d67c1b7ecbce223346b 65bd0a32f144f9e0c9ba35b3ba141729d369c473 M bin

I tested it by realoading the page each time after having cleared the browser's cache and seeing whether the player would start playing immediately, still having the play button shown.

mangui added a commit that referenced this issue Jul 15, 2015
…FERING playback state (instead of PLAYING_BUFFERING)

related to #204
related to #326
mangui added a commit that referenced this issue Jul 15, 2015
related to #326
@mangui
Copy link
Owner

mangui commented Jul 15, 2015

@zuzzurro thanks for bisecting, indeed the issue was related to this commit : b2b47d1
i fixed it the right way, plz recheck with latest flashls/dev
cheers,
Mangui

@zuzzurro
Copy link
Author

if all bugs were this easy :-)
Checked and it seems to work.

@mangui
Copy link
Owner

mangui commented Jul 15, 2015

great ! closing then ...

@mangui mangui closed this as completed Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants