Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for employee org data #99

Merged
merged 5 commits into from
Sep 13, 2021

Conversation

michaljirman
Copy link
Contributor

Add support for employee org data to the User model

@@ -1144,6 +1144,7 @@ type User struct {
UsageLocation *StringNullWhenEmpty `json:"usageLocation,omitempty"`
UserPrincipalName *string `json:"userPrincipalName,omitempty"`
UserType *string `json:"userType,omitempty"`
EmployeeOrgData *EmployeeOrgData `json:"employeeOrgData,omitempty"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michaljirman! Could we move this up to maintain sorting of the field names?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@manicminer manicminer added the enhancement New feature or request label Sep 9, 2021
@manicminer manicminer added this to the v0.29.0 milestone Sep 9, 2021
Copy link
Owner

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

Will merge later today after 0.28.1 is cut.

@manicminer manicminer merged commit 9d93151 into manicminer:main Sep 13, 2021
manicminer added a commit that referenced this pull request Sep 13, 2021
manicminer pushed a commit to kaovd/hamilton that referenced this pull request Sep 30, 2021
* add support for employee org data

* code refactor
manicminer added a commit to kaovd/hamilton that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants