Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose correct types for contract #82

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Expose correct types for contract #82

merged 1 commit into from
Apr 8, 2020

Conversation

sslotsky
Copy link
Contributor

@sslotsky sslotsky commented Apr 8, 2020

No description provided.

@sslotsky sslotsky requested review from a team and davejsdev and removed request for a team April 8, 2020 16:33
davejsdev
davejsdev suggested changes Apr 8, 2020
View reviewed changes
Copy link

@davejsdev davejsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, isn't there an attempts number in there too?

https://github.com/manifoldco/manifold-init/pull/81/files#diff-04cbb1081bc5cfa508e3ee3487b9c6a0R17

@sslotsky
Copy link
Contributor Author

sslotsky commented Apr 8, 2020

Wait, isn't there an attempts number in there too?

https://github.com/manifoldco/manifold-init/pull/81/files#diff-04cbb1081bc5cfa508e3ee3487b9c6a0R17

attempts is only for the internal function. The one we expose externally doesn't accept that parameter.

davejsdev
davejsdev approved these changes Apr 8, 2020
View reviewed changes
Copy link

@davejsdev davejsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, never mind it's taken out of the exposed fucntion

@sslotsky sslotsky merged commit 383be1a into master Apr 8, 2020
@sslotsky sslotsky deleted the sslotsky/ts-fail branch April 8, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davejsdev davejsdev davejsdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sslotsky @davejsdev