Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(Proxy): remove unneeded fallback function
https://forum.openzeppelin.com/t/proxy-sol-fallback/36951/8 The fallback alone would indeed be enough. Fallback is not limited to` msg.value == 0` (if its marked `payable`). Both functions can support value. The difference between receive and fallback is in the msg.data. If the calldata is empty and if there is a receive function, it fill be used. Otherwise, fallback is used. This means that regardless of the value, fallback will be called if there is some data. `fallback` is also the one that is called if there is no data, but receive is not defined. So why do we have a receive function that is not really needed? To silent solidity warnings that sometimes happen when you have a fallback function but no receive function. - @Amxx see <OpenZeppelin/openzeppelin-contracts#4434 (comment)>
- Loading branch information