Android mobile improvements #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
IanPhilips
commented
Aug 24, 2023
•
IanPhilips
commented
- Opens in-app android browser for links with target ='_blank'
- Changes internal facing links to target = '_self'. This includes a hack for iframe embeds of markets on native.
- Adds workarounds for severed native<->client communication post android OOM: window.ReactNativeWebView.postMessage is not a function react-native-webview/react-native-webview#2680
- Removes Sentry, the remote mobile logging monitor as it was causing android build problems 😢
…n <a> tag for native
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
IanPhilips
commented
Aug 24, 2023
| }, 250) | ||
| } | ||
| }, [listeningToNative, fbUser]) | ||
| const sendWebviewAuthInfo = (user: FirebaseUser) => { |
There was a problem hiding this comment.
Now that this is called directly, if the auth.onAuthStateChanged actually works and we were using it, we won't get updates automatically from the useEffect. If people are left signed out we'll probably want to add this back in.
IanPhilips
commented
Aug 24, 2023
| baseUri + | ||
| (endpoint ?? 'home') + | ||
| nativeQuery + | ||
| `&rand=${Math.random().toString()}` |
There was a problem hiding this comment.
Adding a random string ensures the <WebView/> src parameter will treat a new url from our setUrlToLoad as a new state even if it was previously set to the same url. this is useful bc we don't track url changes outside of the webview, just new ones the user imports from a deeplink or notification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.