Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance AppData file #397

Merged
merged 3 commits into from
Jan 14, 2019
Merged

Enhance AppData file #397

merged 3 commits into from
Jan 14, 2019

Conversation

scx
Copy link
Contributor

@scx scx commented Jan 13, 2019

@manisandro
Copy link
Owner

Could you use the same indentation as before for the appdata file so that what actually changed is easily recognizable?

@scx
Copy link
Contributor Author

scx commented Jan 14, 2019

@manisandro

Could you use the same indentation as before for the appdata file so that what actually changed is easily recognizable?

Sorry. Flathub maintainers tend to block pull requests due to trivialities such as "inappropriate" (in their opinion) indentation.

Convert single-space indent to double-space indent:

sed -i -re 's/^( +)/\1\1/' gimagereader.appdata.xml.in

Convert double-space indent to single-space indent:

sed -i -re 's/^( +)\1/\1/' gimagereader.appdata.xml.in

@manisandro manisandro merged commit 881ca13 into manisandro:master Jan 14, 2019
@manisandro
Copy link
Owner

Thanks, I'll follow up with a whitespace-change commit to double-space indent then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants