Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support UTF-8 Email #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support UTF-8 Email #57

wants to merge 2 commits into from

Conversation

kiznick
Copy link

@kiznick kiznick commented Sep 9, 2021

No description provided.

@houd1ni houd1ni mentioned this pull request Mar 5, 2023
Open
@houd1ni
Copy link
Collaborator

houd1ni commented Mar 5, 2023

Hi! Thanks for contributing! Could you please check compatibility and compare it with this PR: #58 ?

This was referenced Mar 5, 2023
Open
Open
Open
@kiznick
Copy link
Author

kiznick commented Mar 10, 2023

PR: #58 Support only Thai language but my PR all utf8 are supported.

@houd1ni
Copy link
Collaborator

houd1ni commented Mar 11, 2023 •
edited
Loading

PR: #58 Support only Thai language but my PR all utf8 are supported.

Looks like very huge range added. Does it support only allowed characters ?

Why exactly these ranges \u00A0-\uD7FF, \uF900-\uFDCF, \uFDF0-\uFFEF ?
Should be noted somewhere. At least in this PR comments.

Also, size limit varies with each utf character at least: https://www.rfc-editor.org/rfc/rfc6532#section-3.4

Also as UASG028 in stated, some unicode stuff could be confusing like here
image

I think it should probably marked as experimental and placed below a flag or a plugin.
Please consider reviewing all above while I'm looking for a better option to include the functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement merge conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiznick @houd1ni