ZSA Voyager (or how to deal with one less thumb?)

[TaiSHiNet]

Hi all,

Just saw the announcement for the ZSA Voyager and, while it's beautiful, it lacks the extra thumb on each side.
What would be a "correct" (using the term very loosely here) adaptation from Miryoku?
I guess H/D could (or V/K) be used for mods depending on how well the thumbs reach them

Looking forward to hearing your thoughts!

[manna-harbour]

• Key Emulation Combos #56
• https://github.com/manna-harbour/miryoku_qmk/tree/miryoku/users/manna-harbour_miryoku#thumb-combos

I'll add support for Voyager to Miryoku QMK soon.

[TaiSHiNet]

That's amazing, thanks! Also thank you for your hard work

[manna-harbour]

Voyager will be added to Miryoku Oryx when time permits, using the native hand position and thumb combos.

Voyager is not yet in QMK master, so Voyager won't yet be added to Miryoku QMK in the miryoku branch, but has been added in a temporary branch. Voyager for QMK is at https://github.com/zsa/qmk_firmware/tree/firmware22/keyboards/voyager and Voyager for Miryoku QMK is at https://github.com/manna-harbour/miryoku_qmk/tree/voyager-test/users/manna-harbour_miryoku#voyager. The ZSA fork of QMK is too different to merge, so it can't be built using the Miryoku QMK workflow merge branch feature. You'll have to merge manually or copy files until ZSA make a PR to QMK.

The more comfortable alternative layouts included for Ergodox in Miryoku QMK won't be possible due to lack of keys. However MIRYOKU_MAPPING=SHIFTED_ROWS is possible and has been included, and will probably be more comfortable than the native hand position and thumb combos, included as the default.

• Create test branch for use with ZSA fork
• Update test branch when PR is available: ZSA Voyager (or how to deal with one less thumb?) #241 (reply in thread)
• Add to miryoku branch when PR is merged
• Add Voyager to Miryoku Oryx

[manna-harbour]

@drashna has now opened a PR for Voyager in QMK: qmk/qmk_firmware#22181. The PR branch is https://github.com/drashna/qmk_firmware/tree/keyboard/zsa_voyager. The keyboard directory has changed from keyboards/voyager to keyboards/zsa/voyager. The voyager-test branch above has been adjusted to match.

To build, merge the voyager-test branch and the PR branch. If using the Miryoku QMK build workflows, select the voyager-test branch in the workflow branch selector, use zsa/voyager with the keyboard field, and use drashna/qmk_firmware/keyboard/zsa_voyager with the merge field. Here's a sample build run: https://github.com/manna-harbour/miryoku_qmk/actions/runs/6956266218.

[davidsteinberger]

This is working great. The only issue that I have, is, that caps lock does not work for me. Caps word works. @manna-harbour any idea what could be causing this?

[elisiano]

@manna-harbour in case you'd like a starting point for the Miryoku Oryx, I've just finished my first Voyager implementation, you can find it here.

It's not super complete compared to the qmk implementation, but I used your moonlander layout as reference (also, I implemented as shifted rows because I needed space for the thumbs).

[alexwaibel]

Took a stab at this by shifting the keys up one and using one of the bottom row keys as the missing thumb key.
https://configure.zsa.io/voyager/layouts/g9gZ4/latest/0

[manna-harbour]

@mitcdh

Oryx doesn't support tap/hold distinction for combos

Thanks for the info! In that case the Miryoku Oryx version will have to use shifted rows instead, like the Miryoku QMK option.

[mitcdh]

This is the source that Oryx generates:

const uint16_t PROGMEM combo0[] = { KC_ENTER, KC_BSPACE, COMBO_END};
const uint16_t PROGMEM combo1[] = { KC_MEDIA_PLAY_PAUSE, KC_MEDIA_STOP, COMBO_END};
const uint16_t PROGMEM combo2[] = { KC_KP_MINUS, KC_0, COMBO_END};
const uint16_t PROGMEM combo3[] = { KC_RPRN, KC_UNDS, COMBO_END};
const uint16_t PROGMEM combo4[] = { KC_TAB, KC_SPACE, COMBO_END};
const uint16_t PROGMEM combo5[] = { LT(5,KC_ENTER), LT(4,KC_BSPACE), COMBO_END};
const uint16_t PROGMEM combo6[] = { LT(1,KC_SPACE), LT(2,KC_TAB), COMBO_END};

combo_t key_combos[COMBO_COUNT] = {
    COMBO(combo0, KC_DELETE),
    COMBO(combo1, KC_AUDIO_MUTE),
    COMBO(combo2, KC_KP_DOT),
    COMBO(combo3, KC_LPRN),
    COMBO(combo4, KC_APPLICATION),
    COMBO(combo5, OSL(6)),
    COMBO(combo6, OSL(3)),
};

So I imagine it's still possible to do without shifted rows, maybe just not through an Oryx configurator-compatible web distribution.

[manna-harbour]

@mitcdh

I imagine it's still possible to do without shifted rows, maybe just not through an Oryx configurator-compatible web distribution

Shifted rows is this:

https://github.com/manna-harbour/miryoku_qmk/tree/voyager-test/users/manna-harbour_miryoku#voyager

An alternative subset mapping is provided with all keys shifted up one row creating thumb keys in the original alpha area. To select this mapping, append MIRYOKU_MAPPING=SHIFTED_ROWS to the make command line when building.

That's an option in Miryoku QMK for voyager (and ergodox, and will be added to moonlander by request). That can also be done in Oryx, and will be used in Miryoku Oryx for voyager if Oryx lacks full combo support.

[manna-harbour]

@martinezj

I've tried several times to compile the QMK file and I can't get it to work.

Due to #287, automatic merging in the workflow as described at #241 (reply in thread) no longer works. You'll have to manually copy https://github.com/drashna/qmk_firmware/tree/keyboard/zsa_voyager/keyboards/zsa/voyager into https://github.com/manna-harbour/miryoku_qmk/tree/voyager-test/keyboards/zsa/voyager.

[mitcdh]

@mitcdh

Oryx doesn't support tap/hold distinction for combos

Thanks for the info! In that case the Miryoku Oryx version will have to use shifted rows instead, like the Miryoku QMK option.

I have the kludge combos working with this: https://configure.zsa.io/voyager/layouts/pzGDD/rL7Pb/0

[davidsteinberger]

ZSA's fork is quite a bit behind, so I went the copy/paste route. Here's what I did.

git clone https://github.com/zsa/qmk_firmware.git
git clone https://github.com/manna-harbour/miryoku_qmk.git
cd ./miryoku_qmk
git checkout voyager-test
cd ../qmk_firmware
git checkout firmware23
mkdir -p ./users/manna-harbour_miryoku
mkdir -p ./keyboards/voyager/keymaps/manna-harbour_miryoku
cp -r ../miryoku_qmk/users/manna-harbour_miryoku ./users
cp -r ../miryoku_qmk/keyboards/voyager/keymaps/manna-harbour_miryoku ./keyboards/voyager/keymaps
make git-submodule

manually delete line 15 in ./users/manna-harbour_miryoku/config.h (#define IGNORE_MOD_TAP_INTERRUPT)
@manna-harbour is there any other way to do it?

make clean voyager:manna-harbour_miryoku

[martinezj]

@davidsteinberger I can't thank you enough for the step by step, this is exactly what I needed. I went through the steps and it worked perfectly, I just loaded the firmware on the Voyager and it's working great so far. Thanks again for your help with this. @manna-harbour if you have any additional advise it would also be greatly appreciated.

[martinezj]

@davidsteinberger if it's not too much to ask could I see your custom_config.h. file to see an example of how you added a mapping for the top row. I'm so happy to have the board working after the help you gave me.

[davidsteinberger]

Here is a simplified version of mine. I removed some changes for combos that I have as well as they also require changes to manna-harbour_miryoku.c.

custom_config.h.txt

[martinezj]

Perfect! Thanks again.

[manna-harbour]

Also see #241 (reply in thread).

[BugRoger]

Here's a working Miryoku build based on the new qmk_userspace. It builds a default Miryoku as well as my customized keymap with Achordion and shifted rows. Super easy to build with the Github actions.

https://github.com/BugRoger/qmk_userspace/