Adding a middleware that ensures api key authentication. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manosim
requested changes
Mar 16, 2017
There was a problem hiding this comment.
Wow! Amazing work @umgelurgel! Really appreciate it! Let's fix the tests and ship this one! 🎉
requirements/requirements-base.txt
Outdated
| @@ -1 +1,2 @@ | |||
| Django==1.10.6 | |||
There was a problem hiding this comment.
Can you remove Django since the CI will run the tests against these versions of Django?
There was a problem hiding this comment.
Sure - how should the version of django be specified in the requirements then? Otherwise, when working locally you need to install requirements and django.
added 2 commits
March 28, 2017 17:52
Add the api key to the requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.