Skip to content

Commit

Permalink
Use alpine linux for base image in Dockerfile
Browse files Browse the repository at this point in the history
  • Loading branch information
mansuf committed Jul 14, 2024
1 parent 866a084 commit 71b4697
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 33 deletions.
66 changes: 34 additions & 32 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
docker-dockerhub-build-and-push:
name: Docker build and push (hub.docker.com)
runs-on: ubuntu-latest
if: startsWith(github.ref, 'refs/tags/') && github.repository == 'mansuf/mangadex-downloader'
# if: startsWith(github.ref, 'refs/tags/') && github.repository == 'mansuf/mangadex-downloader'
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -89,26 +89,27 @@ jobs:
push: true
tags: |
${{ env.DOCKERHUB_LATEST_TAG }}
mansuf/mangadex-downloader:${{ github.ref_name }}
- name: Build and push (with optional dependencies)
uses: docker/build-push-action@v5
with:
context: .
file: Dockerfile.optional
platforms: |
linux/amd64
linux/arm64
linux/arm/v7
push: true
tags: |
${{ env.DOCKERHUB_LATEST_OPTIONAL_TAG }}
mansuf/mangadex-downloader:${{ github.ref_name }}-optional
# mansuf/mangadex-downloader:${{ github.ref_name }}

# - name: Build and push (with optional dependencies)
# uses: docker/build-push-action@v5
# with:
# context: .
# file: Dockerfile.optional
# platforms: |
# linux/amd64
# linux/arm64
# linux/arm/v7
# push: true
# tags: |
# ${{ env.DOCKERHUB_LATEST_OPTIONAL_TAG }}
# mansuf/mangadex-downloader:${{ github.ref_name }}-optional

docker-aws-ecr-build-and-push:
name: Docker build and push (public.ecr.aws)
runs-on: ubuntu-latest
if: startsWith(github.ref, 'refs/tags/') && github.repository == 'mansuf/mangadex-downloader'
# if: startsWith(github.ref, 'refs/tags/') && github.repository == 'mansuf/mangadex-downloader'
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -138,21 +139,22 @@ jobs:
push: true
tags: |
${{ env.AWS_ECR_LATEST_TAG }}
public.ecr.aws/n3n5b0s8/mansuf/mangadex-downloader:${{ github.ref_name }}
- name: Build and push (with optional dependencies)
uses: docker/build-push-action@v5
with:
context: .
file: Dockerfile.optional
platforms: |
linux/amd64
linux/arm64
linux/arm/v7
push: true
tags: |
${{ env.AWS_ECR_LATEST_OPTIONAL_TAG }}
public.ecr.aws/n3n5b0s8/mansuf/mangadex-downloader:${{ github.ref_name }}-optional
# public.ecr.aws/n3n5b0s8/mansuf/mangadex-downloader:${{ github.ref_name }}

# - name: Build and push (with optional dependencies)
# uses: docker/build-push-action@v5
# with:
# context: .
# file: Dockerfile.optional
# platforms: |
# linux/amd64
# linux/arm64
# linux/arm/v7
# push: true
# tags: |
# ${{ env.AWS_ECR_LATEST_OPTIONAL_TAG }}
# public.ecr.aws/n3n5b0s8/mansuf/mangadex-downloader:${{ github.ref_name }}-optional

windows-build:
name: Build app & docs (Windows)
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3.11
FROM python:3.11-alpine

COPY . /app
WORKDIR /app
Expand Down

0 comments on commit 71b4697

Please sign in to comment.