Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on inserting null value for numeric fields in Elastic-like bulk request #2407

Closed
5 tasks done
Nick-S-2018 opened this issue Jul 11, 2024 · 2 comments
Closed
5 tasks done

Comments

@Nick-S-2018
Copy link
Collaborator

Nick-S-2018 commented Jul 11, 2024

Bug Description:

Daemon crashes in the following case:

curl localhost:9408/cli -d 'create table test(f int)' 

curl localhost:9408/_bulk -H "Content-Type: application/x-ndjson"  -d '
{"index":{"_index":"test"}}
{"f":null}
'

The crash also happens for boolean and other numeric fields( bigint, float).
searchd.log

We must fix this and convert null to default data type values in such cases.

Manticore Search Version:

Manticore 6.3.3 5e900a7f6@24070916

Operating System Version:

Ununtu 22.04 LTS

Have you tried the latest development version?

Yes

Internal Checklist:

To be completed by the assignee. Check off tasks that have been completed or are not applicable.

  • Implementation completed
  • Tests developed
  • Documentation updated
  • Documentation reviewed
  • Changelog updated
@tomatolog
Copy link
Contributor

seems like a regression #2363

tomatolog added a commit that referenced this issue Jul 12, 2024
…) for all values; added cases to test 454; fixed #2406 #2407
@tomatolog
Copy link
Contributor

fixed at 0f9c12b now null could be inserter \ replaced \ used in bulk for any attribute or full-text field that set default value for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants