Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The SANS GUI is in the Framework #37952

Open
cailafinn opened this issue Sep 10, 2024 · 0 comments · May be fixed by #38047
Open

The SANS GUI is in the Framework #37952

cailafinn opened this issue Sep 10, 2024 · 0 comments · May be fixed by #38047
Assignees
@cailafinn
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. SANS Issues and pull requests related to SANS
Milestone
Release 6.12

Comments

@cailafinn
Copy link
Contributor

Currently, the ISIS SANS interface is located in mantid/scripts/Interface/ui/sans_ISIS. mantid/scripts is part of the mantid package, intended to only contain the framework and be runnable entirely from the command line or a python script.

The SANS Interface should only be available in the mantidqt and mantidworkbench packages where Qt5 is available and the interface is actually able to launch. This will also help to reduce the size of the framework, which is convenient for anyone who only needs the basic mantid package (such as autoreduction).

Heavy testing will be required to ensure that no workflows are disrupted by the change, doubly so as python won't tell you there are problems until runtime.
@cailafinn cailafinn added ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. SANS Issues and pull requests related to SANS labels Sep 10, 2024
@cailafinn cailafinn added this to the Release 6.12 milestone Sep 10, 2024
@cailafinn cailafinn self-assigned this Sep 13, 2024
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 19, 2024
@cailafinn
Move the SANS GUI out of the Framework.
121d522 
RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 20, 2024
@cailafinn
Remove double-stacked modules
1e33503 
There's not really any point in having SANS.sans everywhere.

RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 20, 2024
@cailafinn
Remove accidental comment renames
b4a5b1f 
The models test directory has been renamed to model_tests. This
resulted in PyCharm being a little overzelous with what should be
updated after this name change.

RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 20, 2024
@cailafinn
Tidy sans readme
c4f07b0 
RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 20, 2024
@cailafinn
Add a release note
6ae8cd5 
RE mantidproject#37952
@cailafinn cailafinn linked a pull request Sep 20, 2024 that will close this issue
Open
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 26, 2024
@cailafinn
Fix sans module path
f9d1263 
RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 26, 2024
@cailafinn
Move the SANS GUI out of the Framework.
1da861a 
RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 26, 2024
@cailafinn
Remove double-stacked modules
4849d4a 
There's not really any point in having SANS.sans everywhere.

RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 26, 2024
@cailafinn
Remove accidental comment renames
e8324b8 
The models test directory has been renamed to model_tests. This
resulted in PyCharm being a little overzelous with what should be
updated after this name change.

RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 26, 2024
@cailafinn
Tidy sans readme
9e5c758 
RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 26, 2024
@cailafinn
Add a release note
9c6c34f 
RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 26, 2024
@cailafinn
Fix sans module path
38a09aa 
RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 26, 2024
@cailafinn
Add missing test import paths
7913b4c 
RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 27, 2024
@cailafinn
Rename to sans_core to avoid git issues
9f2f317 
RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 27, 2024
@cailafinn
Rename to sans_core to avoid git issues
0dae6eb 
RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 27, 2024
@cailafinn
Rename to sans_core to avoid git issues
121a834 
RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 27, 2024
@cailafinn
Rename to sans_core to avoid git issues
00e89ab 
RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 30, 2024
@cailafinn
Rename to sans_core to avoid git issues
d932fe1 
RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Sep 30, 2024
@cailafinn
Fix incorrect imports and mocks
3462e3f 
RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Oct 1, 2024
@cailafinn
Return to original core module name
8066cbb 
This is to try and get around a git renaming with uppercase to
lowercase.

RE mantidproject#37952
cailafinn added a commit to cailafinn/mantid that referenced this issue Oct 2, 2024
@cailafinn
Fix merge conflicts
ac57930 
RE mantidproject#37952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cailafinn cailafinn

Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. SANS Issues and pull requests related to SANS
Projects
ISIS LSS Sprint Planning
Status: In Progress
Mantid Maintenance
Status: In progress
Milestone
Release 6.12
Development

Successfully merging a pull request may close this issue.

Move the ISIS SANS Interface Out of the Framework. cailafinn/mantid
1 participant
@cailafinn