Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Testing Engineering Diffraction #37992

Closed
MohamedAlmaki opened this issue Sep 17, 2024 · 10 comments
Closed

Manual Testing Engineering Diffraction #37992

MohamedAlmaki opened this issue Sep 17, 2024 · 10 comments
Assignees
Labels
Manual Tests Only for issues that are unscripted testing tasks during the release period
Milestone

Comments

@MohamedAlmaki
Copy link
Contributor

You have been assigned manual testing. The hope is to catch as many problems with the code before release, so it would be great if you can take some time to give a serious test to your assigned area. Thank you!!

The general guide to manual testing:

  • The tests must be performed on the installer versions of the final release candidate. Not on local compiled code.
  • Serious errors involving loss of functionality, crashes etc. should be raised
    as issues with the current release as a milestone and an email sent to the project manager immediately.
  • Minor and cosmetic issues should be raised as issues against the forthcoming
    releases.
  • First try things that should work, then try to break Mantid, e.g. entering invalid values, unexpected characters etc.
  • Don't spend more than a few hours on the testing as fatigue will kick in.
  • If you find errors in the documentation, please correct them.
  • Comment against this ticket the OS environment you are testing against.
  • Disable Usage reporting before you start testing
  • Close the this issue once you are done.
  • Time how long this manual test takes for you to do and leave a comment about it in this issue.

Specific Notes:

https://developer.mantidproject.org/Testing/EngineeringDiffraction/EngineeringDiffractionTestGuide.html

@MohamedAlmaki MohamedAlmaki added the Manual Tests Only for issues that are unscripted testing tasks during the release period label Sep 17, 2024
@MohamedAlmaki MohamedAlmaki added this to the Release 6.11 milestone Sep 17, 2024
@Despiix
Copy link
Collaborator

Despiix commented Sep 18, 2024

Engineering Diffraction Analysis:
During test 1 (Calibration) when hovering over the plots I got this error.

Traceback (most recent call last):
File "C:\MantidNightlyInstall\bin\lib\site-packages\matplotlib\cbook_init_.py", line 314, in process
func(*args, **kwargs)
File "C:\MantidNightlyInstall\bin\lib\site-packages\workbench\plotting\figureinteraction.py", line 141, in on_scroll
self._correct_for_scroll_event_on_legend(event)
File "C:\MantidNightlyInstall\bin\lib\site-packages\workbench\plotting\figureinteraction.py", line 174, in _correct_for_scroll_event_on_legend
if legend.get_draggable() and legend.contains(event):
AttributeError: 'NoneType' object has no attribute 'get_draggable'

@jhaigh0
Copy link
Contributor

jhaigh0 commented Sep 18, 2024

Focus step of test 1. Can't find the vanadium run 307521. (IDAaaS)

@jclarkeSTFC
Copy link
Contributor

I'm having problems using the archive on macOS so I can't follow the testing instructions

@jhaigh0
Copy link
Contributor

jhaigh0 commented Sep 18, 2024

Engineering Diffraction Analysis: During test 1 (Calibration) when hovering over the plots I got this error.

Traceback (most recent call last): File "C:\MantidNightlyInstall\bin\lib\site-packages\matplotlib\cbook__init__.py", line 314, in process func(*args, **kwargs) File "C:\MantidNightlyInstall\bin\lib\site-packages\workbench\plotting\figureinteraction.py", line 141, in on_scroll self._correct_for_scroll_event_on_legend(event) File "C:\MantidNightlyInstall\bin\lib\site-packages\workbench\plotting\figureinteraction.py", line 174, in _correct_for_scroll_event_on_legend if legend.get_draggable() and legend.contains(event): AttributeError: 'NoneType' object has no attribute 'get_draggable'

I can recreate this when scrolling on the plot

@Despiix
Copy link
Collaborator

Despiix commented Sep 18, 2024

Cannot follow test instructios, red * will not dissapear.

@jhaigh0
Copy link
Contributor

jhaigh0 commented Sep 18, 2024

Loading the data on idaaas via the run numbers is too unreliable, can't perform the manual tests

@jhaigh0
Copy link
Contributor

jhaigh0 commented Sep 18, 2024

Issue for scrolling created
#38015

@GuiMacielPereira
Copy link
Contributor

Noticed that on IDAaaS, the data cache search is still failing, so re-opened #37398

@GuiMacielPereira
Copy link
Contributor

I followed though the rest of the instructions and had no further issues. Took some time to install GSASII on Linux due to timeout errors. Didn't keep track of time as I did it over several smaller sessions but I estimate it to be between 1h15 - 1h30.

@Despiix
Copy link
Collaborator

Despiix commented Sep 19, 2024

Finished testing except, the last test because I couldn't find the correct GSAS-II path. Time ~2hrs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Manual Tests Only for issues that are unscripted testing tasks during the release period
Projects
None yet
Development

No branches or pull requests

5 participants