Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search for ENGIN-X files in the instrument data cache #37398

Open
GuiMacielPereira opened this issue May 20, 2024 · 2 comments · May be fixed by #38027
Open

Fix search for ENGIN-X files in the instrument data cache #37398

GuiMacielPereira opened this issue May 20, 2024 · 2 comments · May be fixed by #38027
Assignees
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Milestone

Comments

@GuiMacielPereira
Copy link
Contributor

Describe the bug
The search for files in the data cache is not working for Engin-X files.
This is because when we query the instrument from the config service in Mantid, it comes back as ENGIN-X, with an hyphen, while the path in the data cash is built without an hyphen, ENGINX.

Expected behavior
The path to ENGINX files is correctly found.

@GuiMacielPereira GuiMacielPereira added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels May 20, 2024
@GuiMacielPereira GuiMacielPereira added this to the Release 6.10 milestone May 20, 2024
@GuiMacielPereira GuiMacielPereira self-assigned this May 20, 2024
@GuiMacielPereira
Copy link
Contributor Author

This discrepancy is due to ENGINX being the only instrument in the data cache using the short form of the instrument name, while all of the other instruments use the long form. I asked the IDAaaS team if they could change this so that all instruments use the long version, i.e. change ENGINX to ENGIN-X

@GuiMacielPereira
Copy link
Contributor Author

The previous work fixed part of this issue so that the correct index file /data/instrument/ENGINX/ENGINX_index.json is found but I am re-opening it because the path that is returned still contains the name ENGIN-X instead of ENGINX. This means that the search for ENGINX files is still failing in the data cache. Somehow we didn't catch this before, probably because we didn't have the necessary permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
Status: Ready for Review
Status: Done
Status: Done
Status: Done
1 participant