Fix ENGINX data cache search on IDAaaS #38027
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes sure that the path is built relative to the json index file that was opened. Before, the short name might have been used but the path was being constructed with the long name nonetheless. This fix fixes access to ENGINX files on the data cache.
GuiMacielPereira
added
Bug
The path separator on windows is different from the one on linux, so I changed the output path to match the default separator of the OS using make_preferred() and changed unit tests to check this path.
GuiMacielPereira
force-pushed
the
fix-enginx-data-cache
branch
from
31b4da1
to
8c3758d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
From the issue described in #37398, the ENGINX files were still not being found in the data cache because part of the path was still using
ENGIN-Xinstead ofENGINX.Summary of work
I changed a few lines of code that ensure that when the shortname of the instrument is used (
ENGINX) to find the index file, the path is also constructed consistently with this, and uses the shortname version.Access ENGINX files easily on IDAaaS from the data cache.
Fixes #37398 .
Further detail of work
To test:
Test with build number 892.
Load ENGINX files on IDAaaS with the debug log enabled and check that the data cache is used.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.