Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to pylint from the buildscripts, cmake, and documentation #37860

Closed
peterfpeterson opened this issue Aug 22, 2024 · 0 comments · Fixed by #38082
Closed
Assignees
Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Milestone

Comments

@peterfpeterson
Copy link
Member

peterfpeterson commented Aug 22, 2024

Describe the outcome that is desired.
Some time ago we switched all of our static analysis to use ruff which is configured here. Remove the pylint configuration from the builds, docs, and build server configuration. This will reduce maintanence.

Describe any solutions you are considering
Remove pylint from

$ rg -i pylint buildconfig/ -l
buildconfig/Jenkins/leeroy.md
buildconfig/Jenkins/pylint-buildscript
buildconfig/CMake/CommonSetup.cmake
buildconfig/CMake/FindPylint.cmake
buildconfig/CMake/PylintSetup.cmake
buildconfig/wrap_pyui.py

and tools/Pylint/ then make sure the builds still pass. The suppressions in .py files should not be removed as they suppress issues found by ruff.

@peterfpeterson peterfpeterson added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Aug 22, 2024
@thomashampson thomashampson added the ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS label Aug 23, 2024
@thomashampson thomashampson self-assigned this Aug 23, 2024
@thomashampson thomashampson added this to the Release 6.11 milestone Aug 23, 2024
@sf1919 sf1919 modified the milestones: Release 6.11, Release 6.12 Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants