Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Pylint configuration #38082

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Remove unused Pylint configuration #38082

merged 2 commits into from
Oct 1, 2024

Conversation

thomashampson
Copy link
Contributor

@thomashampson thomashampson commented Sep 25, 2024

Description of work

Remove all Pylint config and tools

Purpose of work

We no longer use Pylint, and a lot of the functionality is now covered by ruff.

Fixes #37860

Further detail of work

  • I couldn't find any reference to Pylint in the docs/dev-docs, so nothing has been removed from docs.
  • The leeroy.md file is still out of date but there is another issue to update that. Here I have just removed the Pylint stuff.
  • The Pylint suppressions have been intentionally left in place because they may work with the ruff linter.

To test:

Make sure the builds are fine.

This does not require release notes because it's a removal of config for a tool we no longer use


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@thomashampson thomashampson added this to the Release 6.12 milestone Sep 25, 2024
@thomashampson thomashampson added ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Dependencies Pull requests that update a dependency file Technical Debt Marks a piece of work to address technical debt introduced to solve a problem quickly Maintenance Unassigned issues to be addressed in the next maintenance period. labels Sep 25, 2024
@thomashampson thomashampson marked this pull request as ready for review September 26, 2024 08:41
@jhaigh0 jhaigh0 self-assigned this Sep 30, 2024
Copy link
Contributor

@jhaigh0 jhaigh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solution build worked with no problems. Can't find any more pyline references other than ones from #pyline: disable comments, but I think we're leaving them because ruff will also listen to them. Some of them do look like they could use reviewing though.

@SilkeSchomann SilkeSchomann self-assigned this Sep 30, 2024
@SilkeSchomann
Copy link
Contributor

SilkeSchomann commented Sep 30, 2024

@jhaigh0 Is it worthwhile opening a maintenance task for reviewing #pyline: disable?

@thomashampson
Copy link
Contributor Author

@jhaigh0 Is it worthwhile opening a maintenance task for reviewing #pyline: disable?

Yes do that. We can also investigate whether there are any Pylint checks we want to turn on in ruff.

@SilkeSchomann SilkeSchomann merged commit f94d911 into main Oct 1, 2024
10 checks passed
@SilkeSchomann SilkeSchomann deleted the 37860_remove_pylint branch October 1, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period. Technical Debt Marks a piece of work to address technical debt introduced to solve a problem quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all references to pylint from the buildscripts, cmake, and documentation
3 participants