Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid qtconsole 5.5.0 #36416

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Avoid qtconsole 5.5.0 #36416

merged 2 commits into from
Nov 15, 2023

Conversation

thomashampson
Copy link
Contributor

@thomashampson thomashampson commented Nov 15, 2023

Description of work

Disallow qtcosnole v5.5.0 in conda recipes and developer environments.

Purpose of work

Using tab completion in the IPython console in mantid workbench raises a TypeError with this version of qtconsole. There is an issue on their repo to fix it, so we can assume it will be fixed in later releases.

There is no associated issue.

To test:

check the build log of the packaging job and ensure that qtconsole 5.5.0 isn't installed when packaging workbench.

This does not require release notes because it won't be visible to users (hopefully).


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@thomashampson thomashampson changed the title Avoid qtconsole 5 5 0 Avoid qtconsole 5.5.0 Nov 15, 2023
@thomashampson thomashampson added Dependencies Pull requests that update a dependency file High Priority An issue or pull request that if not addressed is severe enough to postponse a release. labels Nov 15, 2023
@thomashampson thomashampson marked this pull request as ready for review November 15, 2023 16:25
@peterfpeterson peterfpeterson added this to the Release 6.9 milestone Nov 15, 2023
Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works. I'm going to make a follow-on PR for a different way of specifying the version.

@AndreiSavici AndreiSavici merged commit 13cfff1 into main Nov 15, 2023
9 checks passed
@AndreiSavici AndreiSavici deleted the avoid_qtconsole_5_5_0 branch November 15, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants