Update Cppcheck to v2.15.0 #37945
Open
Update Cppcheck to v2.15.0 #37945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @thomashampson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
thomashampson
force-pushed
the
37906_update_cppcheck_to_2_15_0
branch
from
b0901e7
to
200c7d4
Compare
github-actions
bot
removed
the
Has Conflicts
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @thomashampson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
|
I'm pushing this back to 6.12 otherwise there's too much risk of causing conflicts for other people trying to get things in for 6.11 today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Update to cppcheck v2.15.0
Summary of work
Update dependency version and generate new list of suppressions.
Fixes #37906
To test:
No functional testing to be carried out. The cppcheck defects can be seen here:
https://builds.mantidproject.org/job/pull_requests-cppcheck/61087/CppCheck/
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.