Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated checklist for QA managers #38032

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

SilkeSchomann
Copy link
Contributor

Description of work

Added instruction to QA manager checklist for ensuring that both conda and non-conda installations are covered for all operating systems.

There is no associated issue.

To test:

Check that the new instruction makes sense and that grammar and spelling are correct.

This does not require release notes because fit is an update of the developer documentation.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@SilkeSchomann SilkeSchomann added the Documentation Issues and pull requests related to documentation label Sep 19, 2024
@SilkeSchomann SilkeSchomann added this to the Release 6.12 milestone Sep 19, 2024
@rbauststfc rbauststfc self-assigned this Sep 30, 2024
Copy link
Contributor

@rbauststfc rbauststfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've built the dev-docs-html target and the new bullet point renders well. The new instruction is written clearly and is easy to understand.

@robertapplin robertapplin self-assigned this Sep 30, 2024
@robertapplin robertapplin merged commit 4a93399 into main Sep 30, 2024
10 checks passed
@robertapplin robertapplin deleted the update_release_checklist branch September 30, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants