Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elwin allow processing ILL data #38033

Conversation

robertapplin
Copy link
Contributor

@robertapplin robertapplin commented Sep 19, 2024

Description of work

This PR makes it possible to process ILL data with a y axis in units of "Degrees" to be processed on the Elwin tab of the Inelastic Data Processor interface.

Fixes #38035

To test:

Follow the testing instructions in the attached issue. It should not error.

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@robertapplin robertapplin added Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS ILL Team Issues and pull requests managed by the ILL development team labels Sep 19, 2024
@robertapplin robertapplin added this to the Release 6.12 milestone Sep 19, 2024
@robertapplin robertapplin force-pushed the 0-elwin-larger-preview-workspace-box branch from d68b96a to 9683d81 Compare September 19, 2024 12:56
@robertapplin robertapplin marked this pull request as ready for review September 27, 2024 14:35
@robertapplin robertapplin marked this pull request as draft October 11, 2024 12:45
@robertapplin robertapplin force-pushed the 0-elwin-larger-preview-workspace-box branch from 9683d81 to 17654a2 Compare October 11, 2024 16:16
@robertapplin robertapplin force-pushed the 0-elwin-larger-preview-workspace-box branch from 17654a2 to a140b36 Compare October 11, 2024 16:17
@robertapplin robertapplin marked this pull request as ready for review October 12, 2024 14:16
Copy link
Contributor

@mpatrou mpatrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

@SilkeSchomann SilkeSchomann self-assigned this Oct 24, 2024
@SilkeSchomann SilkeSchomann merged commit 8faad57 into mantidproject:main Oct 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ILL Team Issues and pull requests managed by the ILL development team Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Ability to process ILL data in Elwin when y axis is units of Degrees
3 participants