Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace relative and absolute differences with new operations #38067

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

rboston628
Copy link
Contributor

@rboston628 rboston628 commented Sep 20, 2024

Description of work

Summary of work

Several places in mantid meant to show equality within a tolerance, were replaced with the new ops from FloatingPointComparison.cpp, which were added in PR #37931

Purpose of work

To better standardize how mantid handles near-equality. This is mostly to give better visibility to these operations.

There is no associated issue.

Further detail of work

In-line comparison ops in several locations were replaced with calls to functions defined in FloatingPointComparison

To test:

Make sure all tests pass. No behavior should be changed as a result of this PR.

This does not require release notes because it does not impact user experience


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@rboston628 rboston628 changed the title try changes on jenkins if they run Replace relative and absolute differences with new operations Sep 20, 2024
@rboston628 rboston628 force-pushed the ewm7196-replace-comparisons branch 2 times, most recently from 33a9ae0 to c08f06c Compare October 1, 2024 20:12
@github-actions github-actions bot added the Has Conflicts Used by the bot to label pull requests that have conflicts label Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

👋 Hi, @rboston628,

Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

@github-actions github-actions bot removed the Has Conflicts Used by the bot to label pull requests that have conflicts label Oct 10, 2024
@rboston628 rboston628 marked this pull request as ready for review October 11, 2024 15:00
@rboston628 rboston628 added this to the Release 6.12 milestone Oct 11, 2024
@rboston628 rboston628 added the ORNL Team Issues and pull requests managed by the ORNL development team label Oct 22, 2024
@rboston628 rboston628 removed the ORNL Team Issues and pull requests managed by the ORNL development team label Oct 22, 2024
Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are mechanical and very little has changes in tests which suggests this is a true refactor.

Thank you for fixing some of the cppcheck issues

@peterfpeterson peterfpeterson added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Oct 22, 2024
@KedoKudo KedoKudo merged commit 5c14034 into main Oct 22, 2024
10 checks passed
@KedoKudo KedoKudo deleted the ewm7196-replace-comparisons branch October 22, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants