Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matplotlib 3.8 update #38077

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Matplotlib 3.8 update #38077

wants to merge 4 commits into from

Conversation

Despiix
Copy link
Collaborator

@Despiix Despiix commented Sep 25, 2024

Description of work

Summary of work

Update Matplotlib to 3.8.4 from 3.7

Further detail of work

To test:


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

… contour plots by looking for the ContourSet collection in ax.collections.

Co-authored-by: Gui Pereira <gui.maciel-pereira@stfc.ac.uk>
Co-authored-by: Sam Jones <samuel.jones@stfc.ac.uk>

https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.8.0.html#contourset-is-now-a-single-collection
…axes using Prop_cycler is removed from the newer versions of Matplotlib.
@Despiix Despiix self-assigned this Sep 25, 2024
@Despiix Despiix added the ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS label Sep 25, 2024
@Despiix Despiix added this to the Release 6.12 milestone Sep 25, 2024
@Despiix Despiix added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Sep 25, 2024
… we had different versions of mpl on different OS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant